-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reflection_Engine: SortExtensionMethods fixed to work on generics #2345
Reflection_Engine: SortExtensionMethods fixed to work on generics #2345
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes the problem
@BHoMBot check compliance |
@pawelbaran to confirm, |
/azp run BHoM_Engine.CheckInstaller |
Azure Pipelines successfully started running 1 pipeline(s). |
@BHoMBot check core |
@pawelbaran to confirm, |
@BHoMBot check installer |
@pawelbaran to confirm, |
Issues addressed by this PR
Closes #2344
Test files
On SharePoint - the results do not matter, the methods should just trigger.
Changelog
SortExtensionMethods
fixed to work on genericsAdditional comments
@adecler it would be great if you could prioritise this PR as it breaks quite a few things across the entire engine 😭
An alternative fix could also be move the -1 level methods to the end of the returned list instead of ruling them out:
BHoM_Engine/Reflection_Engine/Modify/SortExtensionMethods.cs
Line 47 in 3762274