Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Facade_Engine: ConvertOffsetDefinition #2285

Merged

Conversation

vgreen-BH
Copy link
Contributor

Issues addressed by this PR

Closes #2266

Added method SetOffsetFromFacetoFaceDefinition to Facade_Engine Methods. This method takes a user input offset (defined from face of glazing to face of panel) and applies it as a ConstructionOffsetFragment to an opening.

@vgreen-BH vgreen-BH added this to the BHoM 4.1 β RC milestone Jan 27, 2021
@vgreen-BH vgreen-BH requested a review from enarhi January 27, 2021 23:46
@vgreen-BH vgreen-BH self-assigned this Jan 27, 2021
@enarhi
Copy link
Member

enarhi commented Feb 1, 2021

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 1, 2021

@enarhi to confirm, check-code-compliance, check-documentation-compliance, check-project-compliance, check-branch-compliance, check-dataset-compliance, and, if applicable, check-copyright-compliance tasks are now queued.

Copy link
Member

@enarhi enarhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@enarhi
Copy link
Member

enarhi commented Feb 1, 2021

/azp run BHoM_Engine.CheckInstaller

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@FraserGreenroyd FraserGreenroyd merged commit ed1edc8 into master Feb 1, 2021
@FraserGreenroyd FraserGreenroyd deleted the Facade_Engine-#2266-ConvertOffsetDefinitions branch February 1, 2021 20:45
@FraserGreenroyd FraserGreenroyd added the type:feature New capability or enhancement label Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Facade_Engine: Add method to convert between offset definitions
3 participants