Reflection_Engine: Fix SetProperty of CustomData #2281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@BHoMBot check copyright |
|
@BHoMBot check copyright compliance |
|
@FraserGreenroyd to confirm, |
FraserGreenroyd
requested changes
Jan 26, 2021
Co-authored-by: Fraser Greenroyd <[email protected]>
Co-authored-by: Fraser Greenroyd <[email protected]>
FraserGreenroyd
approved these changes
Jan 27, 2021
There was a problem hiding this comment.
Wording LGTM now, will leave @pawelbaran to do a final functionality review has he raised the issue to be fixed 😄
pawelbaran
approved these changes
Jan 27, 2021
|
@BHoMBot check installer |
|
@pawelbaran to confirm, |
|
/azp run BHoM_Engine.CheckInstaller |
|
@BHoMBot check copyright |
|
@pawelbaran to confirm, |
|
Azure Pipelines successfully started running 1 pipeline(s). |
FraserGreenroyd
deleted the
Reflection_Engine-#362-FixSetPropertyOfCustomData
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues addressed by this PR
Closes #2284
Changing a value stored in CustomData is now possible even if the corresponding key already exists
Test files
See issue
Changelog
Additional comments