Versioning_Engine: Add support for custom message on items without an upgrade #2273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adecler
added
type:compliance
adecler
requested review from
alelom,
rolyhudson,
FraserGreenroyd,
IsakNaslundBh and
pawelbaran
| @@ -91,7 +91,12 @@ public static BsonDocument ToNewVersion(this BsonDocument document, string versi | |||
| // Get the new version back | |||
| BsonDocument result = ReadDocument(pipe); | |||
| if (result != null) | |||
| document = result; | |||
| { | |||
| if (result.Contains("_t") && result["_t"] == "NoUpdate" && result.Contains("Message")) | |||
There was a problem hiding this comment.
Maybe a dumb question from not having read in detail everything on the Versioning_TK PR, but if the result contains _t and that type is of NoUpdate but the result does not contain a message, do we still want to set the document = result;?
There was a problem hiding this comment.
Thanks @FraserGreenroyd, Good catch. That should never happen since we are responsible for both end of the pipeline but better safe than sorry 😄 . Code updated
adecler
force-pushed
the
Versioning_Toolkit-#117-MessageForItemWithoutUpdate
branch
2 times, most recently
from
f224278 to
f984eb0
Compare
adecler
force-pushed
the
Versioning_Toolkit-#117-MessageForItemWithoutUpdate
branch
from
f984eb0 to
745b0d8
Compare
|
@BHoMBot check copyright |
|
@adecler to confirm, |
|
/azp run BHoM_Engine.CheckInstaller |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@BHoMBot check installer |
|
@adecler to confirm, |
|
/azp run BHoM_Engine.CheckInstaller |
|
Azure Pipelines successfully started running 1 pipeline(s). |
adecler
deleted the
Versioning_Toolkit-#117-MessageForItemWithoutUpdate
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues addressed by this PR
Supports this PR in the Versioning Toolkit: BHoM/Versioning_Toolkit#134
See that PR for more details