-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Geometry_Engine: Removing Radius(Arc) and adding warnings to Area() methods #2262
Conversation
@BHoMBot check compliance |
@FraserGreenroyd to confirm, |
@BHoMBot check documentation compliance |
@FraserGreenroyd to confirm, |
@BHoMBot check core |
@LMarkowski to confirm, |
/azp run BHoM_Engine.CheckCore |
Azure Pipelines successfully started running 1 pipeline(s). |
@BHoMBot check compliance |
@LMarkowski to confirm, |
/azp run BHoM_Engine.CheckInstaller |
Azure Pipelines successfully started running 1 pipeline(s). |
Should get into the Habit of putting testiles (even small as the one you used @LMarkowski ) on sharepoint, in a folder easily identifiable with the PR. I put the file you shared as well as a quick test that the area methods are still working and messages fire correctly here @LMarkowski : |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code change looks good to me.
Issues addressed by this PR
Closes #945
Closes #946
Deprecating
Query.Radius(Arc)
asRadius
is a public property of theArc
class.EDIT
Decided to merge this one with #946 as they both update
Area.cs
and I didn't want to wait until this one get merged 😉/EDIT
Test files
945
Not needed as it doesn't affect a logic of any method, however here is the script I used to check if any reference has been missed.
946
Not needed - only added warnings.
Changelog
Query.Radius(Arc)
method in theGeometry_Engine
.Geometry_Engine
to call forRadius
property instead ofRadius()
method.Query.Area
methods in theGeometry_Engine
in cases of open curves.