Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Copyright Header to 2021 #2253

Merged
merged 3 commits into from
Jan 5, 2021
Merged

Update Copyright Header to 2021 #2253

merged 3 commits into from
Jan 5, 2021

Conversation

BHoMBot
Copy link
Member

@BHoMBot BHoMBot commented Jan 4, 2021

Closes #2252

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 4, 2021

@BHoMBot just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM

1 similar comment
@bhombot-ci
Copy link

bhombot-ci bot commented Jan 4, 2021

@BHoMBot just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check copyright compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 4, 2021

@FraserGreenroyd to confirm, check-copyright-compliance task is now queued.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check copyright compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 4, 2021

@FraserGreenroyd to confirm, check-copyright-compliance task is now queued.

@FraserGreenroyd
Copy link
Contributor

/azp run BHoM_Engine.CheckInstaller

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

FraserGreenroyd
FraserGreenroyd previously approved these changes Jan 4, 2021
View reviewed changes
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, would be good for at least one other review if possible.

adecler
adecler requested changes Jan 5, 2021
View reviewed changes
Copy link
Member

@adecler adecler left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested programmatically with this script. Two files need fixing:

BHoM_Engine\Spatial_Engine\Compute\MapDomain.cs
BHoM_Engine\Spatial_Engine\Modify\MapPositionDomain.cs

Both have a double copyright header.

Also worth mentioning that the following file has been flagged up for having a double copyright:

BHoM_Engine\Serialiser_Engine\Objects\MemberMapConventions\ImmutableBHoMCreatorMapConvention.cs

One is ours, one is MongoDB Inc since this is a file we copied from them. So might be better not to add our copyright on that one.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check copyright compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 5, 2021

@FraserGreenroyd to confirm, check-copyright-compliance task is now queued.

@FraserGreenroyd
Copy link
Contributor

/azp run BHoM_Engine.CheckInstaller

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@FraserGreenroyd FraserGreenroyd added the type:compliance Non-conforming to code guidelines label Jan 5, 2021
adecler
adecler approved these changes Jan 5, 2021
View reviewed changes
Copy link
Member

@adecler adecler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reran the test and all looks good now

FraserGreenroyd
FraserGreenroyd approved these changes Jan 5, 2021
View reviewed changes
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed the test @adecler has been using and it looks robust so will give this PR another couple of hours for other reviews and then will merge by 12PM UTC.

@FraserGreenroyd FraserGreenroyd merged commit c34e0e8 into master Jan 5, 2021
@FraserGreenroyd FraserGreenroyd deleted the BHoMBot-UpdateCopyright2021 branch January 5, 2021 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FraserGreenroyd FraserGreenroyd FraserGreenroyd approved these changes

@adecler adecler adecler approved these changes

@al-fisher al-fisher Awaiting requested review from al-fisher al-fisher is a code owner

@alelom alelom Awaiting requested review from alelom alelom is a code owner

@epignatelli epignatelli Awaiting requested review from epignatelli epignatelli is a code owner

@IsakNaslundBh IsakNaslundBh Awaiting requested review from IsakNaslundBh IsakNaslundBh is a code owner

@kayleighhoude kayleighhoude Awaiting requested review from kayleighhoude kayleighhoude is a code owner

@pawelbaran pawelbaran Awaiting requested review from pawelbaran pawelbaran is a code owner

@rwemay rwemay Awaiting requested review from rwemay rwemay is a code owner

@tg359 tg359 Awaiting requested review from tg359 tg359 is a code owner

Assignees
No one assigned
Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compliance of BHoM file Copyright Headers
3 participants
@BHoMBot @FraserGreenroyd @adecler