BHoM_Engine: add Query.Hash() extension method

[alelom]

Issues addressed by this PR

Closes #2060

Test files

[adecler]

A few minor things but otherwise looks good.

I wonder if it wouldn't make more sense to have the Hash method that takes all the arguments to be in Query though. It kind of feels weird that one is in Query and one is in Compute since the only difference is their number of arguments.

[al-fisher]

Looks good @alelom - added a small suggested change to one of the descriptions to distinguish

[al-fisher]

As discussed @alelom - unexpected behaviour between the two hash methods returning different results for same input

[alelom]

@al-fisher thanks - fixed in 6ba0075

[al-fisher]

Perfect - this is working as expected now! Thanks

[adecler]

Isn't it a bit problematic that a call to Query.Hash(item) is actually undetermined between the two methods ?

[alelom]

Isn't it a bit problematic that a call to Query.Hash(item) is actually undetermined between the two methods ?

Sorry, I can't see where the problem is – the overload with the closest number of argument is always called by C#, so it's not undetermined?

Am I missing something?

[al-fisher]

Thanks for mopping up those descriptions @alelom 😄

[adecler]

/azp run BHoM_Engine.CheckCore

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[adecler]

/azp run BHoM_Engine.CheckInstaller

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[adecler]

@alelom , sorry I was just bothered by this: return Hash(iObj, null, null, null, null, 100);
The fact that you have to provide the default arguments to the method for it to be differentiated from Hash(iObj) is not ideal (for example, what if you change the default value of those arguments later ?).

But that's not a big deal at all so that's fine.