Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Environment_Engine: assign construction by type #2010

Merged

Conversation

linaeriksson
Copy link
Contributor

Issues addressed by this PR

#1975 Environment_Engine: Method for assigning Construction by Panel/Opening.Type

Closes #1975

Panels can now be assigned to newContruction by ConstructionType

@FraserGreenroyd FraserGreenroyd changed the title Environment engine #1975 assign construction by type Environment_Engine: assign construction by type Oct 5, 2020
@FraserGreenroyd FraserGreenroyd added the type:feature New capability or enhancement label Oct 5, 2020
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor documentation and styling please

/***************************************************/

public static List<Panel> SetPanelConstructionByType(this List<Panel> panels, IConstruction newConstruction, PanelType panelType)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this blank line

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tack @linaeriksson 😄

@FraserGreenroyd
Copy link
Contributor

/azp run BHoM_Engine.CheckInstaller

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@FraserGreenroyd FraserGreenroyd merged commit 6f86947 into master Oct 5, 2020
@FraserGreenroyd FraserGreenroyd deleted the Environment_Engine-#1975-assign_construction_by_type branch October 5, 2020 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Environment_Engine: Method for assigning Construction by Panel/Opening.Type
2 participants