Analytical_Engine: Adding support for IRegion #1970
Conversation
IsakNaslundBh
requested review from
al-fisher,
FraserGreenroyd,
pawelbaran and
LMarkowski
| @@ -171,5 +171,17 @@ public static Face Geometry(this IFace face) | |||
| return geomFace; | |||
| } | |||
|
|
|||
| /***************************************************/ | |||
|
|
|||
| [Description("Gets the geometry of a IRegion as its Perimiter curve. Method required for automatic display in UI packages.")] | |||
There was a problem hiding this comment.
Not only for that, but also for RunExtensionMethod pattern - may be worth mentioning
There was a problem hiding this comment.
hmm, true. Not sure if that adds info to the user or not though? Saying that, not sure the current comment does either!
There was a problem hiding this comment.
Not sure about the user, but could be good to capture that in the API? I am not sure how many people will reach the RunExtensionMethod Wiki page.
The above may be a more general question to all get/set geometry methods, therefore happy to approve the PR as is.
Co-authored-by: Pawel Baran <[email protected]>
| public static IRegion SetOutlineElements1D(this IRegion region, IEnumerable<IElement1D> outlineElements) | ||
| { | ||
| IRegion r = region.GetShallowClone(true) as IRegion; | ||
| r.Perimeter = BH.Engine.Geometry.Compute.IJoin(outlineElements.Cast<ICurve>().ToList())[0]; |
There was a problem hiding this comment.
I would consider adding a check if the output of IJoin contains only 1 item and if that item is closed - if not, raise a warning that the output may be wrong.
Good point pawel. Missed that I never uploaded the testfile. Have put it on sharepoint, link in description, if you want to have a quick test! |
|
/azp run BHoM_Engine.CheckInstaller |
|
Azure Pipelines successfully started running 1 pipeline(s). |
NOTE: Depends on
BHoM/BHoM#985
Issues addressed by this PR
BHoM/BHoM#970
Adding IElement2D methods required for IRegion.
https://github.com/BHoM/documentation/wiki/IElement-required-extension-methods
Test files
https://burohappold.sharepoint.com/:f:/s/BHoM/ElcGHiplcxxJuRsZYz9ewx8BkczFetyKcjcxAhclljhVSw?e=Pdksu3
Changelog
Additional comments