Data_Engine: Uncommenting code for getting all values from a Table #1921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run BHoM_Engine.CheckInstaller |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues addressed by this PR
Closes #1920
Uncommenting out the code for getting out all values from a table.
This was commented out in #1833 which did not have anything to do with the tables.
@rolyhudson would you mind testing that the spatial trees are unaffected by this?
Test files
Testfiles from PR where this was commented out:
https://burohappold.sharepoint.com/:u:/s/BHoM/EaZM91qyXmVAo4ddZrneV6wB_1m8DlJ-Eq_PbDIsAlHoSQ?e=hxg7KS
And a more lightweight version:
https://burohappold.sharepoint.com/:u:/s/BHoM/Ec3OChqs5IpAvnWqCFjkTm4BJP_IaX6Z52Fg7R4BTgzHXw?e=yaG3zj
Changelog
Additional comments