Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data_Engine: Quality of life for DomainTree #1867

Merged
merged 6 commits into from
Jul 1, 2020

Conversation

kThorsager
Copy link
Contributor

Issues addressed by this PR

Closes #

some support methods for DomainTree to alleviate working with it

Test files

Not needed

Changelog

  • added tolerance to ItemsInRange as well

Additional comments

@kThorsager kThorsager added the type:feature New capability or enhancement label Jun 29, 2020
@kThorsager kThorsager self-assigned this Jun 29, 2020
@kThorsager kThorsager marked this pull request as ready for review June 29, 2020 11:10
@kThorsager
Copy link
Contributor Author

kThorsager commented Jun 29, 2020

Hm, the branch has the latest commit but not the PR, unsure of how that happened. (pushed it during the github issues, but I can see the commit on Github 🤷‍♂️)

973d4d7

Copy link
Member

@pawelbaran pawelbaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No complaints about the code itself, a few minor cleanups requested.

Spatial_Engine/Create/DomainTree.cs Outdated Show resolved Hide resolved
Spatial_Engine/Create/DomainTree.cs Outdated Show resolved Hide resolved
Spatial_Engine/Create/DomainTree.cs Outdated Show resolved Hide resolved
Spatial_Engine/Spatial_Engine.csproj Outdated Show resolved Hide resolved
Data_Engine/Create/DomainTreeLeaf.cs Outdated Show resolved Hide resolved
Copy link
Member

@pawelbaran pawelbaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@pawelbaran
Copy link
Member

/azp run BHoM_Engine.CheckInstaller

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@IsakNaslundBh IsakNaslundBh merged commit 00ebab4 into master Jul 1, 2020
@IsakNaslundBh IsakNaslundBh deleted the Data_Engine-QualityOfLife-DomainTree branch July 1, 2020 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants