Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geometry_Engine: null checks in Bounds #1844

Conversation

kThorsager
Copy link
Contributor

Issues addressed by this PR

Closes #710
as title

Test files

The standard one is very broken, but the items still appear through the UI, and doubt adding null checks would do anything worse than having an null exception somewhere else in the code

Changelog

Additional comments

@kThorsager kThorsager added the type:bug Error or unexpected behaviour label Jun 15, 2020
@kThorsager kThorsager requested a review from al-fisher as a code owner June 15, 2020 14:08
@kThorsager kThorsager self-assigned this Jun 15, 2020
Copy link
Member

@pawelbaran pawelbaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pawelbaran
Copy link
Member

/azp run BHoM_Engine.CheckInstaller

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@FraserGreenroyd FraserGreenroyd merged commit e76fb0e into master Jun 16, 2020
@FraserGreenroyd FraserGreenroyd deleted the Geometry_Engine-#710-Bounds-throws-breaks-when-objects-are-null branch June 16, 2020 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Geometry_Engine: Bounds throws breaks when objects are null
3 participants