Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Structure_Engine: Adding comparer checking numbers for ICase objects #1790

Merged
merged 1 commit into from
May 26, 2020

Conversation

IsakNaslundBh
Copy link
Contributor

Issues addressed by this PR

Closes #1763

Adding comparer checking numbers for ICase objects

Test files

Will link to test file making use of the comparer in Robot, as soon as Robot is free to push code to.

Changelog

Additional comments

@IsakNaslundBh IsakNaslundBh added the type:feature New capability or enhancement label May 21, 2020
@IsakNaslundBh IsakNaslundBh added this to the BHoM 3.2 β MVP milestone May 21, 2020
@IsakNaslundBh IsakNaslundBh requested a review from kThorsager May 21, 2020 15:33
@IsakNaslundBh IsakNaslundBh requested a review from rwemay as a code owner May 21, 2020 15:33
@IsakNaslundBh IsakNaslundBh self-assigned this May 21, 2020
@IsakNaslundBh
Copy link
Contributor Author

/azp run BHoM_Engine.CheckCompliance

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@kThorsager kThorsager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IsakNaslundBh
Copy link
Contributor Author

/azp run BHoM_Engine.CheckInstaller

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@IsakNaslundBh IsakNaslundBh merged commit 2801061 into master May 26, 2020
@IsakNaslundBh IsakNaslundBh deleted the Structure_Engine-#1763-AddCaseNumberComparer branch May 26, 2020 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Structure_Engine: Add CaseNumberComparer
2 participants