Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Structure_Engine: Remove Common_Engine reference #1783

Merged
merged 3 commits into from
May 20, 2020
Merged

Structure_Engine: Remove Common_Engine reference #1783

merged 3 commits into from
May 20, 2020

Conversation

kThorsager
Copy link
Contributor

Issues addressed by this PR

#1624
and allows for #1759 to work

@kThorsager kThorsager added the type:compliance Non-conforming to code guidelines label May 20, 2020
@kThorsager kThorsager requested a review from IsakNaslundBh May 20, 2020 07:28
@kThorsager kThorsager requested a review from rwemay as a code owner May 20, 2020 07:28
@kThorsager kThorsager self-assigned this May 20, 2020
@kThorsager
Copy link
Contributor Author

/azp run BHoM_Engine.CheckInstaller

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kThorsager kThorsager changed the title Remove Common_Engine reference Structure_Engine: Remove Common_Engine reference May 20, 2020
@FraserGreenroyd
Copy link
Contributor

/azp run BHoM_Engine.CheckCompliance

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

IsakNaslundBh
IsakNaslundBh requested changes May 20, 2020
View reviewed changes
Copy link
Contributor

@IsakNaslundBh IsakNaslundBh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comment

Structure_Engine/Query/Geometry.cs Outdated Show resolved Hide resolved
IsakNaslundBh
IsakNaslundBh approved these changes May 20, 2020
View reviewed changes
Copy link
Contributor

@IsakNaslundBh IsakNaslundBh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, just re-pointing to the methods that was called via the common engine

@IsakNaslundBh
Copy link
Contributor

/azp run BHoM_Engine.CheckInstaller

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@IsakNaslundBh
Copy link
Contributor

/azp run BHoM_Engine.CheckCompliance

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@IsakNaslundBh IsakNaslundBh merged commit 1e06e70 into master May 20, 2020
@IsakNaslundBh IsakNaslundBh deleted the Structure_Engine-RemoveCommonEngineReference branch May 20, 2020 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IsakNaslundBh IsakNaslundBh IsakNaslundBh approved these changes

@rwemay rwemay Awaiting requested review from rwemay rwemay is a code owner

Assignees

@kThorsager kThorsager

Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kThorsager @FraserGreenroyd @IsakNaslundBh