Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BHoM_Engine: Fix Analytical_Engine and Graphics_Engine CSProj #1751

Merged
merged 3 commits into from
May 7, 2020

Conversation

FraserGreenroyd
Copy link
Contributor

Fixes #1749
Fixes #1750

@FraserGreenroyd FraserGreenroyd added the type:compliance Non-conforming to code guidelines label May 7, 2020
@FraserGreenroyd FraserGreenroyd self-assigned this May 7, 2020
@FraserGreenroyd FraserGreenroyd changed the title Fix CSProj BHoM_Engine: Fix Analytical_Engine and Graphics_Engine CSProj May 7, 2020
@FraserGreenroyd
Copy link
Contributor Author

/azp run BHoM_Engine.CheckCompliance

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@FraserGreenroyd
Copy link
Contributor Author

/azp run BHoM_Engine.CheckCompliance

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@FraserGreenroyd
Copy link
Contributor Author

/azp run BHoM_Engine.CheckInstaller

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@FraserGreenroyd FraserGreenroyd requested a review from kThorsager May 7, 2020 13:24
@kThorsager
Copy link
Contributor

or wait @alelom will this conflict with your PR #1717 ?

@FraserGreenroyd
Copy link
Contributor Author

@kThorsager it might but that is a draft and we want to clean up the installer stuff to start fixing Dynamo so would need to be brought up to date before it's finished I expect anyhow. @alelom are you happy for us to merge this given that status?

@FraserGreenroyd
Copy link
Contributor Author

According to BHoM/TriangleNet_Toolkit#27 that PR replaces #1717 (for further info)

@kThorsager
Copy link
Contributor

Yes, this does seem safe in that case, (but why is the PR still open if the code was transferred? @alelom )

@alelom
Copy link
Member

alelom commented May 7, 2020

Yes, this does seem safe in that case, (but why is the PR still open if the code was transferred? @alelom )

Closing it now. I didn't want the branch to be deleted yet.

@FraserGreenroyd FraserGreenroyd merged commit 137eba6 into master May 7, 2020
@FraserGreenroyd FraserGreenroyd deleted the BHoM_Engine-#1749-CSProj branch May 7, 2020 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compliance issue for CSProj files Compliance issue for CSProj files
3 participants