Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Architecture_Engine: Implement HasMergeablePropertiesWith #1725

Merged
merged 2 commits into from
Apr 30, 2020
Merged

Architecture_Engine: Implement HasMergeablePropertiesWith #1725

merged 2 commits into from
Apr 30, 2020

Conversation

kThorsager
Copy link
Contributor

Issues addressed by this PR

Closes #1671

Test files

Not needed

Changelog

Additional comments

@kThorsager kThorsager added the type:feature New capability or enhancement label Apr 30, 2020
@kThorsager kThorsager self-assigned this Apr 30, 2020
FraserGreenroyd
FraserGreenroyd approved these changes Apr 30, 2020
View reviewed changes
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as discussed, thanks @kThorsager

@FraserGreenroyd
Copy link
Contributor

FraserGreenroyd commented Apr 30, 2020 •
edited
Loading

/azp run BHoM_Engine.CheckInstaller

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@FraserGreenroyd FraserGreenroyd merged commit a0efcb2 into master Apr 30, 2020
@FraserGreenroyd FraserGreenroyd deleted the Architecture_Engine-#1671-Implement-HasMergeablePropertiesWith branch April 30, 2020 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FraserGreenroyd FraserGreenroyd FraserGreenroyd approved these changes

Assignees

@kThorsager kThorsager

Labels
type:feature New capability or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Architecture_Engine: Implement HasMergeablePropertiesWith
2 participants
@kThorsager @FraserGreenroyd