Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Structure_Engine: Implement HasMergeablePropertiesWith #1706

Conversation

kThorsager
Copy link
Contributor

Issues addressed by this PR

Partially handles #1674

Fixes for the Edges which is the pressing matter

Test files

https://burohappold.sharepoint.com/:f:/s/BHoM/En26cTEF-h1Al4qHoBRqSi4Bx81OZ8GJFuI8UHOWWuSiEg?e=obT54u

@kThorsager kThorsager added the type:feature New capability or enhancement label Apr 28, 2020
@kThorsager kThorsager added this to the BHoM 3.2 β MVP milestone Apr 28, 2020
@kThorsager kThorsager requested a review from rwemay as a code owner April 28, 2020 14:47
@kThorsager kThorsager self-assigned this Apr 28, 2020
@FraserGreenroyd
Copy link
Contributor

/azp run BHoM_Engine.CheckCompliance

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @kThorsager - see compliance report please 😄

@kThorsager
Copy link
Contributor Author

/azp run BHoM_Engine.CheckCompliance

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@FraserGreenroyd FraserGreenroyd dismissed their stale review April 28, 2020 15:19

Compliance changes made so I'm happy, thanks @kThorsager

@FraserGreenroyd FraserGreenroyd removed their request for review April 28, 2020 15:19
Copy link
Contributor

@IsakNaslundBh IsakNaslundBh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, all looks fine.

@IsakNaslundBh
Copy link
Contributor

/azp run BHoM_Engine.CheckCompliance

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@IsakNaslundBh
Copy link
Contributor

/azp run BHoM_Engine.CheckInstaller

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@IsakNaslundBh IsakNaslundBh merged commit f0be1da into master Apr 29, 2020
@IsakNaslundBh IsakNaslundBh deleted the Structure_Engine-#1674-Implement-HasMergeablePropertiesWith branch April 29, 2020 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants