Versioning_Engine: method to easily generate method keys for versioning

[adecler]

Issues addressed by this PR

Provide helper method/component to go along with this PR: BHoM/BHoM_UI#247

This makes it way easier to populate the inputs of a PreviousVersion attribute.

[FraserGreenroyd]

Still reviewing functionality wise, but a few comments to be starting with? 😄

[FraserGreenroyd]

Looks like everything is working as described for me from this code 😄

[adecler]

@FraserGreenroyd , I fixed the problems raised in your review

[FraserGreenroyd]

Am happy with the changes and am happy with the output (see previous comment).

[kThorsager]

Perhaps intended due to Modify -> Compute not working but if a method is found in both it returns nothing.

Worth flagging as that is a planned feature (think this one)

[FraserGreenroyd]

Perhaps intended due to Modify -> Compute not working but if a method is found in both it returns nothing.

I think from the demo @adecler gave this morning, the matching starts from the right and works left, so with those inputs it would be looking for BH.Engine.Geometry.Join which of course doesn't exist (based on my understanding of it).

Maybe a warning to the user to say that the provided thing couldn't be found might be worthwhile? Or if the issue you link is the right one then solving that at a later date.

[kThorsager]

Perhaps intended due to Modify -> Compute not working but if a method is found in both it returns nothing.

I think from the demo @adecler gave this morning, the matching starts from the right and works left, so with those inputs it would be looking for BH.Engine.Geometry.Join which of course doesn't exist (based on my understanding of it).

Maybe a warning to the user to say that the provided thing couldn't be found might be worthwhile? Or if the issue you link is the right one then solving that at a later date.

No, sorry, re-read the description and sounds right (but thought the demo showed using just a part of the namespace)

[FraserGreenroyd]

No, sorry, re-read the description and sounds right (but thought the demo showed using just a part of the namespace)

It does, but it started from the right rather than the left. So I think something like Modify and Join would find the right one (or all the ones that match) because there is *.Modify.Join methods if that makes sense?

[adecler]

A simple way to settle that discussion is to look at the code:

return Engine.Reflection.Query.AllMethodList()
                .Where(x => x.Name == methodName && x.DeclaringType.FullName.EndsWith(declaringType))
                .Select(x => x.VersioningKey())
                .ToList();

I was using EndsWith instead of == so that users wouldn't have to figure out whether to provide just the name of the declaring type or its full name (including namespace). The nice side effect was that yo could even do partial namespaces. I do however regret showing you that since it has been misinterpreted. The input name is declaringType. As far as I know, BH.Engine.Geometry is a namespace, not a declaring type.

[adecler]

/azp run BHoM_Engine.CheckInstaller

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).