Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Structure_Engine: Adding comparers for Contraints4DOF and 6DOF from Robot_Toolkit #1689

Merged

Conversation

IsakNaslundBh
Copy link
Contributor

Issues addressed by this PR

Closes #1688

Migrating full comparers for Constraint4DOF and Constraint6DOF from Robot_Toolkit to Structure_Engine

Test files

Changelog

Additional comments

Copy link
Contributor

@kThorsager kThorsager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IsakNaslundBh
Copy link
Contributor Author

/azp run BHoM_Engine.CheckCompliance

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@IsakNaslundBh
Copy link
Contributor Author

/azp run BHoM_Engine.CheckInstaller

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@IsakNaslundBh IsakNaslundBh merged commit 3c5c26e into master Apr 22, 2020
@IsakNaslundBh IsakNaslundBh deleted the Structure_Engine-#1688-MigrateComparersFromRobotToolkit branch April 22, 2020 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Structure_Engine: Migrate comparers from RobotToolkit
2 participants