Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reflection_Engine: Remove boilerplate default descriptions #1685

Merged
merged 2 commits into from
Apr 22, 2020

Conversation

IsakNaslundBh
Copy link
Contributor

Issues addressed by this PR

Closes #1461

  • Removes the "This is a property of...." default description
  • Only add type description for IObjects

Test files

Changelog

Additional comments

@IsakNaslundBh IsakNaslundBh added the type:feature New capability or enhancement label Apr 21, 2020
@IsakNaslundBh IsakNaslundBh added this to the BHoM 3.2 β MVP milestone Apr 21, 2020
@IsakNaslundBh IsakNaslundBh requested a review from al-fisher April 21, 2020 15:14
@IsakNaslundBh IsakNaslundBh self-assigned this Apr 21, 2020
Copy link
Member

@al-fisher al-fisher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With many nice descriptions being populated now think this is a good tidy up! Thanks @IsakNaslundBh
LGTM

@al-fisher
Copy link
Member

/azp run BHoM_Engine.CheckInstaller

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@adecler adecler merged commit bec91c4 into master Apr 22, 2020
@adecler adecler deleted the Reflection_Engine-#1461-DoNotAddDefaultDescriptions branch April 22, 2020 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reflection_Engine: Do not add default description if one is found
3 participants