Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Environment_Engine: Add Interface methods #1678

Merged
merged 6 commits into from
Apr 21, 2020
Merged

Environment_Engine: Add Interface methods #1678

merged 6 commits into from
Apr 21, 2020

Conversation

FraserGreenroyd
Copy link
Contributor

Issues addressed by this PR

Fixes #1672

@FraserGreenroyd FraserGreenroyd added the type:feature New capability or enhancement label Apr 20, 2020
@FraserGreenroyd FraserGreenroyd self-assigned this Apr 20, 2020
kThorsager
kThorsager requested changes Apr 20, 2020
View reviewed changes
Copy link
Contributor

@kThorsager kThorsager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dangers of being first

Environment_Engine/Query/HasMergeablePropertiesWith.cs Outdated Show resolved Hide resolved
Environment_Engine/Query/HasMergeablePropertiesWith.cs Outdated Show resolved Hide resolved
Environment_Engine/Query/HasMergeablePropertiesWith.cs Outdated Show resolved Hide resolved
Environment_Engine/Query/HasMergeablePropertiesWith.cs Outdated Show resolved Hide resolved
@FraserGreenroyd
Copy link
Contributor Author

/azp run BHoM_Engine.CheckCompliance

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

kThorsager
kThorsager approved these changes Apr 21, 2020
View reviewed changes
Copy link
Contributor

@kThorsager kThorsager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works now

@FraserGreenroyd
Copy link
Contributor Author

/azp run BHoM_Engine.CheckInstaller

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@FraserGreenroyd FraserGreenroyd merged commit 415b014 into master Apr 21, 2020
@FraserGreenroyd FraserGreenroyd deleted the Environment_Engine-#1672 branch April 21, 2020 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kThorsager kThorsager kThorsager approved these changes

@IsakNaslundBh IsakNaslundBh Awaiting requested review from IsakNaslundBh IsakNaslundBh is a code owner

@tg359 tg359 Awaiting requested review from tg359 tg359 is a code owner

Assignees

@FraserGreenroyd FraserGreenroyd

Labels
type:feature New capability or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enviorment_Enigine: Implement HasMergeablePropertiesWith
2 participants
@FraserGreenroyd @kThorsager