Reflection_Engine: Migrate Dummy and IsEqual methods to the Test Toolkit #1655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FraserGreenroyd
approved these changes
Apr 14, 2020
There was a problem hiding this comment.
4 files removed and I can see those 4 files have been moved to this PR BHoM/Test_Toolkit#215 so I'm happy to approve this PR. However, I was never experiencing the clash that @enarhi @pawelbaran or @kThorsager were on the Revit UI, so I cannot say for certain that their issue is resolved, but I would be confident it is looking at the code changes in this PR.
|
I got rid of that by cleaning up all Build folders and rebuilding all assemblies and works fine for me now, so cannot test myself. @enarhi @kayleighhoude maybe you can give it a shot? |
|
/azp run BHoM_Engine.CheckInstaller |
|
Azure Pipelines successfully started running 1 pipeline(s). |
FraserGreenroyd
deleted the
Reflection_Engine-#1653-MigrateDummyAndIsEqualMethods
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1653
Move those method to eliminate the dependency to the Kellerman Compare-Object library that is causing issues in code executed outside the BHoM assembly folder.
Test files
Just start Revit and make sure the error highlighted in issues #1653 is not present anymore.