Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default Revit FamilyMaps added #94

Merged

Conversation

pawelbaran
Copy link
Member

@pawelbaran pawelbaran commented Jul 30, 2021

Issues addressed by this PR

Closes #

Test files

It is an empty file for now, correctness of this PR can be checked by creating RevitAdapter on this branch and making sure it does not turn orange.

Changelog

Additional comments

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 30, 2021

@pawelbaran just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @pawelbaran on Revit_Toolkit

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 30, 2021

@pawelbaran just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @pawelbaran on Revit_Toolkit

1 similar comment
@bhombot-ci
Copy link

bhombot-ci bot commented Aug 2, 2021

@pawelbaran just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @pawelbaran on Revit_Toolkit

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 2, 2021

@pawelbaran just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @pawelbaran on Revit_Toolkit

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 2, 2021

@pawelbaran just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @pawelbaran on Revit_Toolkit

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 2, 2021

@pawelbaran just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @pawelbaran on Revit_Toolkit

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 3, 2021

@pawelbaran just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @pawelbaran on Revit_Toolkit

Copy link
Member

@enarhi enarhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, passed build/adapter test.

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 3, 2021

@pawelbaran just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @pawelbaran on Revit_Toolkit

@pawelbaran
Copy link
Member Author

@BHoMBot check dataset-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 3, 2021

@pawelbaran to confirm, the following checks are now queued:

  • dataset-compliance

@pawelbaran
Copy link
Member Author

@BHoMBot check core

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 3, 2021

@pawelbaran to confirm, the following checks are now queued:

  • core

@FraserGreenroyd FraserGreenroyd merged commit deb8350 into master Aug 3, 2021
@FraserGreenroyd FraserGreenroyd deleted the Revit_Toolkit-#1054-NEWTypeAndParameterMapping branch August 3, 2021 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants