Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed US Steel Section names to match AISC Book #66

Merged
merged 2 commits into from
Nov 4, 2020

Conversation

JosefTaylor
Copy link
Contributor

Also changed properties to US Customary units, converted to SI with localisation tools.

NOTE: Depends on

Issues addressed by this PR

Closes #65

Set US Steel section names to AISC Manual values, which hopefully should improve library matching from Revit.
Set properties from US Customary units, converted to SI using localisation toolkit, rather than getting metric quantities from the AISC spreadsheet, which were rounded slightly different to the customary quantities.

Test files

Changelog

Additional comments

Also changed properties to US Customary units, converted to SI with localisation tools.
Copy link
Contributor

@IsakNaslundBh IsakNaslundBh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seem to no longer be in a Dataset class, which means no source information. good to not loose that.

Also, if you update the names, all old dropdown components will fail.

I will, as soon as I find any time, implement a versioning system for the libraries FYI that I hope can help mitigate that, but if this is needed ASAP, might not be able to wait.

@IsakNaslundBh IsakNaslundBh added the type:compliance Non-conforming to code guidelines label Oct 26, 2020
@maryannewachter
Copy link
Member

Fixed source information as requested by @IsakNaslundBh. However, AISC lacks consistency in naming Pipe and Round HSS sections (Manual will say HSS4x0.500, but the database will say HSS4.000x0.500). Suggest that we map similar names to the same existing section somehow.

@JosefTaylor
Copy link
Contributor Author

This looks good to me. Sources and names are correct, values align exactly to the values in the spreadsheet.

Testing the properties against calculated values shows shear areas are not in line with the default BHoM calculation, but these are in line with formulas shown in the design for shear section (G) of the steel manual.

@JosefTaylor JosefTaylor dismissed IsakNaslundBh’s stale review November 3, 2020 22:56

Maryanne added sources

@JosefTaylor
Copy link
Contributor Author

@IsakNaslundBh mind merging this?

@IsakNaslundBh IsakNaslundBh merged commit f42cd0d into master Nov 4, 2020
@IsakNaslundBh IsakNaslundBh deleted the BHoM_Datasets-#65-change-section-names branch November 4, 2020 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use AISC Manual Labels for US Steel SectionProperties
4 participants