Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metal deck datasets #155

Merged
merged 6 commits into from
Apr 10, 2024

Conversation

IsakNaslundBh
Copy link
Contributor

Issues addressed by this PR

Closes #152

Add dataset for RichardLees decking Corrugated deck datasets
Add dataset for SMD corrugated deck datasets

Test files

Data found here

Changelog

Additional comments

@IsakNaslundBh IsakNaslundBh added the type:feature New capability or enhancement label Apr 3, 2024
@IsakNaslundBh IsakNaslundBh self-assigned this Apr 3, 2024
@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check dataset-compliance
@BHoMBot check copyright-compliance
@BHoMBot check project-compliance

Copy link

bhombot-ci bot commented Apr 3, 2024

@IsakNaslundBh to confirm, the following actions are now queued:

  • check dataset-compliance
  • check copyright-compliance
  • check project-compliance

@IsakNaslundBh
Copy link
Contributor Author

IsakNaslundBh commented Apr 3, 2024

@BHoMBot check dataset-compliance
@BHoMBot check copyright-compliance
@BHoMBot check project-compliance

Copy link

bhombot-ci bot commented Apr 3, 2024

@IsakNaslundBh to confirm, the following actions are now queued:

  • check dataset-compliance
  • check copyright-compliance
  • check project-compliance

There are 4 requests in the queue ahead of you.

Copy link
Member

@peterjamesnugent peterjamesnugent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RF51 appears to have a depth of 51mm in SMD.BRO.121.V4-SMD-TAB-Deckmanual but 52mm everywhere else I can find it:
image

How did you calculate the top width for the Ribdeck S60 and 80 products?

…ial information regarding exact dimensions has been found. Can be added back at a later date
@IsakNaslundBh
Copy link
Contributor Author

RF51 appears to have a depth of 51mm in SMD.BRO.121.V4-SMD-TAB-Deckmanual but 52mm everywhere else I can find it: image

How did you calculate the top width for the Ribdeck S60 and 80 products?

Good catches @peterjamesnugent . AS discussed offline, I have updated height to 51 for the R51 SMD deck.

For the RLD S60 and 80 products I have opted to simply remove them for now until an official good source of exact dimensions can be found.

Copy link

bhombot-ci bot commented Apr 9, 2024

@IsakNaslundBh to confirm, the following actions are now queued:

  • check dataset-compliance
  • check copyright-compliance
  • check project-compliance

Copy link
Member

@peterjamesnugent peterjamesnugent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy the RLD dataset deserialises correctly now and the S60/S80 decks have been removed.

@peterjamesnugent
Copy link
Member

@BHoMBot check compliance

Copy link

bhombot-ci bot commented Apr 10, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Apr 10, 2024

@IsakNaslundBh to confirm, the following actions are now queued:

  • check ready-to-merge

Copy link

bhombot-ci bot commented Apr 10, 2024

FAO: @FraserGreenroyd
@IsakNaslundBh is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is ready-to-merge.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 23660791901

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 23660791901

Copy link

bhombot-ci bot commented Apr 10, 2024

@IsakNaslundBh I have now provided a passing check on reference 23660791901 as requested.

@IsakNaslundBh IsakNaslundBh merged commit e5724ee into develop Apr 10, 2024
7 checks passed
@IsakNaslundBh IsakNaslundBh deleted the BHoM_Datasets-#152-AddMetalDeckDatasets branch April 10, 2024 13:06
@bhombot-ci bhombot-ci bot mentioned this pull request Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add MetalDeck datasets
2 participants