-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add metal deck datasets #155
Add metal deck datasets #155
Conversation
@IsakNaslundBh to confirm, the following actions are now queued:
|
@IsakNaslundBh to confirm, the following actions are now queued:
There are 4 requests in the queue ahead of you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RF51 appears to have a depth of 51mm in SMD.BRO.121.V4-SMD-TAB-Deckmanual but 52mm everywhere else I can find it:
How did you calculate the top width for the Ribdeck S60 and 80 products?
…ial information regarding exact dimensions has been found. Can be added back at a later date
Good catches @peterjamesnugent . AS discussed offline, I have updated height to 51 for the R51 SMD deck. For the RLD S60 and 80 products I have opted to simply remove them for now until an official good source of exact dimensions can be found. |
@IsakNaslundBh to confirm, the following actions are now queued:
|
…ted for this value, but using 51 that matches name makes sense
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy the RLD dataset deserialises correctly now and the S60/S80 decks have been removed.
@BHoMBot check compliance |
@peterjamesnugent to confirm, the following actions are now queued:
|
@BHoMBot check ready-to-merge |
@IsakNaslundBh to confirm, the following actions are now queued:
|
FAO: @FraserGreenroyd The check they wish to have dispensation on is ready-to-merge. If you are providing dispensation on this occasion, please reply with:
|
@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 23660791901 |
@IsakNaslundBh I have now provided a passing check on reference |
Issues addressed by this PR
Closes #152
Add dataset for RichardLees decking Corrugated deck datasets
Add dataset for SMD corrugated deck datasets
Test files
Data found here
Changelog
Additional comments