Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove 6.1 PreviousVersion Attributes #138

Merged
merged 1 commit into from
Mar 31, 2023
Merged

Remove 6.1 PreviousVersion Attributes #138

merged 1 commit into from
Mar 31, 2023

Conversation

bhombot-ci[bot]
Copy link

@bhombot-ci bhombot-ci bot commented Mar 31, 2023

Remove 6.1 PreviousVersion Attributes and Versioning JSON files

@FraserGreenroyd FraserGreenroyd added the type:compliance Non-conforming to code guidelines label Mar 31, 2023
@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 31, 2023

@bhombot-ci[bot] just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM_Engine

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 31, 2023

@bhombot-ci[bot] just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check copyright-compliance
@BHoMBot check project-compliance
@BHoMBot check dataset-compliance

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 31, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check copyright-compliance
  • check project-compliance
  • check dataset-compliance

FraserGreenroyd
FraserGreenroyd approved these changes Mar 31, 2023
View reviewed changes
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code checked and attributes removed and checks are happy.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check core

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 31, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check core

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 31, 2023

@bhombot-ci[bot] just to let you know, I have provided a check-ready-to-merge result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM

@FraserGreenroyd FraserGreenroyd merged commit c9bcd4c into develop Mar 31, 2023
@FraserGreenroyd FraserGreenroyd deleted the BHoM-RemovePreviousVersion61 branch March 31, 2023 14:01
@bhombot-ci bhombot-ci bot mentioned this pull request Jun 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FraserGreenroyd FraserGreenroyd FraserGreenroyd approved these changes

Assignees
No one assigned
Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FraserGreenroyd @BHoMBot