-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
6.1 Deployment #136
6.1 Deployment #136
Conversation
@BHoMBot check beta-merge-status |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 39 requests in the queue ahead of you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with beta candidate "230314"
No changes to datasets in Structure/foundational, only migration.
Approving on the basis for structure and foundational (graphics) that:
All dataset version correctly
All dataset serialise correctly, given the correct type back
I have not reviewed the changes to the facades dataset, which require separate review and approval.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed with beta candidate "230315" as per test procedure.
Approving for facades datasets and general functionality.
Confirmed changes to datasets are functioning properly, with expected data in the proper format per the procedure. Additionally spot checked general dataset functionality with no apparent issues from migration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed with beta candidate "230315" as per test procedure.
Confirmed changes to Facade FrameEdgeProperty Dataset are functioning properly, with expected functionality when tested with relevant methods.
Approving for facades datasets only.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed with beta candidates "230316" and "230317" as per test document.
PASS for both beta candidates MEP datasets.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed with beta candidate 03/17/23 and testing procedure linked here
Confirmed Frame Edge Property Dataset is functioning as expected.
Approving for Facades Dataset only.
Improper formatting of review, will resubmit review to just have one properly formatted review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed with beta candidate 03/17/23 and testing procedure linked here
Confirmed Frame Edge Property Dataset is functioning as expected.
Approving for Facades Dataset only.
@BHoMBot check beta-merge-status |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 39 requests in the queue ahead of you. |
MERGE REPORT - 2023-03-19 15:07. DETAILS: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am satisfied with the level of testing this repository has received and am happy for this to be deployed to the 6.1 beta.
Reviewed with beta candidate 03/21/23 and testing procedure linked here Confirmed Frame Edge Property Dataset is functioning as expected. Approving for Facades Dataset only. |
@bhombot-ci[bot] just to let you know, I have provided a |
@bhombot-ci[bot] just to let you know, I have provided a |
@bhombot-ci[bot] just to let you know, I have provided a |
2 similar comments
@bhombot-ci[bot] just to let you know, I have provided a |
@bhombot-ci[bot] just to let you know, I have provided a |
@BHoMBot check compliance |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 103 requests in the queue ahead of you. |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 294 requests in the queue ahead of you. |
@BHoMBot check serialisation |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 383 requests in the queue ahead of you. |
@BHoMBot check ready-to-merge |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 456 requests in the queue ahead of you. |
@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: dataset-compliance, ready-to-merge |
@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results. |
BHoM_Datasets
Feature
Bug
Compliance