Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6.1 Deployment #136

Merged
merged 8 commits into from
Mar 23, 2023
Merged

6.1 Deployment #136

merged 8 commits into from
Mar 23, 2023

Conversation

bhombot-ci[bot]
Copy link

@bhombot-ci bhombot-ci bot commented Mar 13, 2023

@FraserGreenroyd FraserGreenroyd self-requested a review March 13, 2023 18:11
@FraserGreenroyd
Copy link
Contributor

@BHoMBot check beta-merge-status

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 13, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check beta-merge-status

There are 39 requests in the queue ahead of you.

Copy link
Contributor

@IsakNaslundBh IsakNaslundBh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with beta candidate "230314"
No changes to datasets in Structure/foundational, only migration.

Approving on the basis for structure and foundational (graphics) that:

All dataset version correctly
All dataset serialise correctly, given the correct type back

I have not reviewed the changes to the facades dataset, which require separate review and approval.

Copy link
Member

@enarhi enarhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed with beta candidate "230315" as per test procedure.

Approving for facades datasets and general functionality.

Confirmed changes to datasets are functioning properly, with expected data in the proper format per the procedure. Additionally spot checked general dataset functionality with no apparent issues from migration.

Copy link
Contributor

@vgreen-BH vgreen-BH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed with beta candidate "230315" as per test procedure.

Confirmed changes to Facade FrameEdgeProperty Dataset are functioning properly, with expected functionality when tested with relevant methods.

Approving for facades datasets only.

Copy link

@alexissantella alexissantella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed with beta candidates "230316" and "230317" as per test document.

PASS for both beta candidates MEP datasets.

@gideontamir16 gideontamir16 self-requested a review March 17, 2023 19:59
gideontamir16
gideontamir16 previously approved these changes Mar 17, 2023
Copy link

@gideontamir16 gideontamir16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed with beta candidate 03/17/23 and testing procedure linked here

Confirmed Frame Edge Property Dataset is functioning as expected.

Approving for Facades Dataset only.

@gideontamir16 gideontamir16 dismissed their stale review March 17, 2023 20:18

Improper formatting of review, will resubmit review to just have one properly formatted review

@gideontamir16 gideontamir16 self-requested a review March 17, 2023 20:29
Copy link

@gideontamir16 gideontamir16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed with beta candidate 03/17/23 and testing procedure linked here

Confirmed Frame Edge Property Dataset is functioning as expected.

Approving for Facades Dataset only.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check beta-merge-status

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 19, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check beta-merge-status

There are 39 requests in the queue ahead of you.

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 19, 2023

MERGE REPORT - 2023-03-19 15:07.

DETAILS:
This pull request can be merged or not merged without impact on any of its upstream dependencies..

@FraserGreenroyd FraserGreenroyd added status:do-not-merge For instance, test PR, for discussion, or dependant PRs not ready for merge type:feature New capability or enhancement and removed type:feature New capability or enhancement status:do-not-merge For instance, test PR, for discussion, or dependant PRs not ready for merge labels Mar 21, 2023
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am satisfied with the level of testing this repository has received and am happy for this to be deployed to the 6.1 beta.

@gideontamir16
Copy link

Reviewed with beta candidate 03/21/23 and testing procedure linked here

Confirmed Frame Edge Property Dataset is functioning as expected.

Approving for Facades Dataset only.

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 22, 2023

@bhombot-ci[bot] just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on CSharp_Toolkit

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 22, 2023

@bhombot-ci[bot] just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on CSharp_Toolkit

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 22, 2023

@bhombot-ci[bot] just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on CSharp_Toolkit

2 similar comments
@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 22, 2023

@bhombot-ci[bot] just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on CSharp_Toolkit

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 22, 2023

@bhombot-ci[bot] just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on CSharp_Toolkit

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check compliance

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 22, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 103 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check core
@BHoMBot check null-handling

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 22, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check core
  • check null-handling

There are 294 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check serialisation

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 22, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check serialisation

There are 383 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 22, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

There are 456 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: dataset-compliance, ready-to-merge

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 23, 2023

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@FraserGreenroyd FraserGreenroyd merged commit 9e971e2 into main Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants