Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Assembly Version #299

Merged
merged 1 commit into from
Jul 20, 2021
Merged

Update Assembly Version #299

merged 1 commit into from
Jul 20, 2021

Conversation

BHoMBot
Copy link
Member

@BHoMBot BHoMBot commented Jun 28, 2021

Updates Assembly Version to 4.3

FraserGreenroyd
FraserGreenroyd approved these changes Jun 28, 2021
View reviewed changes
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved from a CI/CD perspective.

@FraserGreenroyd FraserGreenroyd added the type:compliance Non-conforming to code guidelines label Jun 28, 2021
@FraserGreenroyd FraserGreenroyd requested a review from alelom June 28, 2021 11:14
IsakNaslundBh
IsakNaslundBh approved these changes Jun 28, 2021
View reviewed changes
Copy link
Contributor

@IsakNaslundBh IsakNaslundBh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 14, 2021

@BHoMBot just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check compliance
@BHoMBot check versioning
@BHoMBot check serialisation
@BHoMBot check null-handling
@BHoMBot check core

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 20, 2021

@FraserGreenroyd to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • branch-compliance
  • dataset-compliance
  • copyright-compliance
  • versioning
  • serialisation
  • null-handling
  • core

There are 2 requests in the queue ahead of you.

@FraserGreenroyd FraserGreenroyd merged commit 48b74bf into master Jul 20, 2021
@FraserGreenroyd FraserGreenroyd deleted the BHoMBot-UpdateAssemblyVersion-43 branch July 20, 2021 09:14
@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 20, 2021

@FraserGreenroyd to confirm, the following checks are now queued:

  • ready-to-merge

There are 17 requests in the queue ahead of you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alelom alelom alelom approved these changes

@FraserGreenroyd FraserGreenroyd FraserGreenroyd approved these changes

@IsakNaslundBh IsakNaslundBh IsakNaslundBh approved these changes

Assignees
No one assigned
Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BHoMBot @FraserGreenroyd @alelom @IsakNaslundBh