Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analytical_oM: Elevate Graph objects from Elements sub folder to own primary folder #1580

Merged
merged 2 commits into from
Jan 12, 2024

Conversation

FraserGreenroyd
Copy link
Contributor

Fixes #1261

Copy link

bhombot-ci bot commented Jan 12, 2024

@FraserGreenroyd just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM_Engine

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check versioning
@BHoMBot check installer

Copy link

bhombot-ci bot commented Jan 12, 2024

@FraserGreenroyd to confirm, the following actions are now queued:

  • check versioning
  • check installer

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check compliance

Copy link

bhombot-ci bot commented Jan 12, 2024

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 1 requests in the queue ahead of you.

Copy link

@Tom-Kingstone Tom-Kingstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On code review: the changes made follow the original issue as set out, and seeing as the bot likes the versioning, I'm happy to approve this.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check core
@BHoMBot check serialisation

Copy link

bhombot-ci bot commented Jan 12, 2024

@FraserGreenroyd to confirm, the following actions are now queued:

  • check core
  • check serialisation

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Jan 12, 2024

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

There are 4 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Jan 12, 2024

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

There are 1 requests in the queue ahead of you.

@FraserGreenroyd FraserGreenroyd merged commit 6a0e87d into develop Jan 12, 2024
11 checks passed
@FraserGreenroyd FraserGreenroyd deleted the Analytical_oM-#1261-ElevateGraph branch January 12, 2024 15:25
@bhombot-ci bhombot-ci bot mentioned this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Analytical_oM: move the "Graph" folder out of "Elements" to the root level.
2 participants