Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7.0 Deployment #1571

Merged
merged 49 commits into from
Dec 20, 2023
Merged

7.0 Deployment #1571

merged 49 commits into from
Dec 20, 2023

Conversation

bhombot-ci[bot]
Copy link

@bhombot-ci bhombot-ci bot commented Dec 11, 2023

BHoM

Feature

Bug

Compliance

Documentation

BHoMBot and others added 30 commits September 25, 2023 14:31
@FraserGreenroyd FraserGreenroyd added type:compliance Non-conforming to code guidelines type:feature New capability or enhancement and removed type:compliance Non-conforming to code guidelines labels Dec 11, 2023
@peterjamesnugent peterjamesnugent self-requested a review December 13, 2023 11:10
Copy link
Member

@peterjamesnugent peterjamesnugent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have run through the test scripts and happy to approve for the following:

  • Ground_oM
  • Physical_oM
  • Structure_oM

@JohnSloane JohnSloane self-requested a review December 17, 2023 21:43
Copy link

@JohnSloane JohnSloane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing using the Lighting_Engine testing procedure. Passed.

@gideontamir16 gideontamir16 self-requested a review December 18, 2023 15:51
@gideontamir16
Copy link

Testing using the Facades_Engine testing procedure. Passed.

@enarhi enarhi self-requested a review December 20, 2023 01:17
Copy link
Member

@enarhi enarhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested for Lighting and Facades per Testing Procedures, passed for both.

@jamesramsden-bh jamesramsden-bh self-requested a review December 20, 2023 16:43
Copy link
Contributor

@jamesramsden-bh jamesramsden-bh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved based on S&P 7.0 testing report

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check compliance

Copy link
Author

bhombot-ci bot commented Dec 20, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check installer

Copy link
Author

bhombot-ci bot commented Dec 20, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check installer

Copy link
Author

bhombot-ci bot commented Dec 20, 2023

@bhombot-ci[bot] just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on Versioning_Toolkit

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check null-handling
@BHoMBot check serialisation

Copy link
Author

bhombot-ci bot commented Dec 20, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check null-handling
  • check serialisation

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PRs have been reviewed by DevOps and are suitable for the deployment of develop to the 7.0 beta. Approving for merge.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: core

Copy link
Author

bhombot-ci bot commented Dec 20, 2023

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 19834519917

Copy link
Author

bhombot-ci bot commented Dec 20, 2023

@FraserGreenroyd I have now provided a passing check on reference 19834519917 as requested.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

Copy link
Author

bhombot-ci bot commented Dec 20, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

Copy link
Author

bhombot-ci bot commented Dec 20, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

@FraserGreenroyd FraserGreenroyd merged commit 0939a89 into main Dec 20, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants