Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Structure_oM: Add direction enum to HollowCore #1505

Merged
merged 1 commit into from
May 5, 2023
Merged

Structure_oM: Add direction enum to HollowCore #1505

merged 1 commit into from
May 5, 2023

Conversation

IsakNaslundBh
Copy link
Contributor

Issues addressed by this PR

Closes #1504

Adds direction enum to the hollow core surface property

Test files

Changelog

Additional comments

@IsakNaslundBh IsakNaslundBh added the type:feature New capability or enhancement label Apr 21, 2023
@IsakNaslundBh IsakNaslundBh self-assigned this Apr 21, 2023
@IsakNaslundBh IsakNaslundBh mentioned this pull request Apr 21, 2023
Merged
@IsakNaslundBh IsakNaslundBh marked this pull request as ready for review April 21, 2023 06:26
@IsakNaslundBh IsakNaslundBh requested a review from rwemay as a code owner April 21, 2023 06:26
Chrisshort92
Chrisshort92 approved these changes May 4, 2023
View reviewed changes
Copy link

@Chrisshort92 Chrisshort92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked functionality and code. Approved.

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check compliance
@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented May 5, 2023

@IsakNaslundBh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@bhombot-ci
Copy link

bhombot-ci bot commented May 5, 2023

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented May 5, 2023

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented May 5, 2023

@IsakNaslundBh to confirm, the following actions are now queued:

  • check ready-to-merge

There are 2 requests in the queue ahead of you.

@IsakNaslundBh IsakNaslundBh merged commit aaf1c39 into develop May 5, 2023
@IsakNaslundBh IsakNaslundBh deleted the Structure_oM-#1504-AddDirectionEnumToHollowCOre branch May 5, 2023 13:30
@bhombot-ci bhombot-ci bot mentioned this pull request Jun 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chrisshort92 Chrisshort92 Chrisshort92 approved these changes

@rwemay rwemay Awaiting requested review from rwemay rwemay is a code owner

Assignees

@IsakNaslundBh IsakNaslundBh

Labels
type:feature New capability or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Structure_oM: Add direction enum to hollow core
2 participants
@IsakNaslundBh @Chrisshort92