Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graphics_oM: Add graphics render texture #1389

Merged
merged 3 commits into from
May 27, 2022

Conversation

IsakNaslundBh
Copy link
Contributor

@IsakNaslundBh IsakNaslundBh commented May 13, 2022

NOTE: Depends on

Issues addressed by this PR

Closes #485

Add graphics texture class to handle rendering of surface and meshes. Defaults to BHoM Pink with no bitmap.

Adding a explicit casting from Colour to Texture to allow easier generation from the UI.

General intended logic of the class is that the Colour property always gives the colour of the edges, while the Texture property gives the colour or texture of the mesh/surface faces. If the texture is not set, the display should fall back on using the colour property instead.

Test files

https://burohappold.sharepoint.com/:f:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/BHoM/Graphics_oM/%231389-AddGraphsicsRenderTexture?csf=1&web=1&e=NxVT3M

Changelog

Additional comments

  • Can also add transparency and bumb maps if we like, but kept it simple, only adding main texture in the first push.
  • Later PR to handle adding a IMaterialProperty with a texture that can be applied to a physical Material class.

@IsakNaslundBh IsakNaslundBh requested a review from enarhi May 17, 2022 16:01
Copy link
Contributor

@michaelhoehn michaelhoehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested and approved this feature. LGTM!

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented May 27, 2022

@IsakNaslundBh to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • branch-compliance
  • dataset-compliance
  • copyright-compliance

There are 147 requests in the queue ahead of you.

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented May 27, 2022

@IsakNaslundBh to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • versioning
  • installer

There are 165 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented May 27, 2022

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented May 27, 2022

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented May 27, 2022

@IsakNaslundBh to confirm, the following checks are now queued:

  • ready-to-merge

There are 153 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented May 27, 2022

FAO: @FraserGreenroyd
@IsakNaslundBh is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is ready-to-merge.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 6622617384

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 6622617384

@bhombot-ci
Copy link

bhombot-ci bot commented May 27, 2022

@FraserGreenroyd I have now provided a passing check on reference 6622617384 as requested.

@IsakNaslundBh IsakNaslundBh merged commit e44f8ad into main May 27, 2022
@IsakNaslundBh IsakNaslundBh deleted the Graphics_oM-#485-AddGraphsicsRenderTexture branch May 27, 2022 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Graphics_oM : Add a Graphics.MaterialFragments.IMaterialFragment
3 participants