Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graphics_oM: add ColourFragment #1049

Merged
merged 3 commits into from
Nov 9, 2020
Merged

Graphics_oM: add ColourFragment #1049

merged 3 commits into from
Nov 9, 2020

Conversation

alelom
Copy link
Member

@alelom alelom commented Oct 29, 2020

NOTE: Depends on

Issues addressed by this PR

Closes #1048

Test files

Changelog

Additional comments

@alelom alelom self-assigned this Oct 29, 2020
@alelom alelom added the type:feature New capability or enhancement label Oct 29, 2020
@FraserGreenroyd FraserGreenroyd changed the title Graphics_oM: add ColorFragment Graphics_oM: add ColourFragment Oct 29, 2020
@alelom alelom mentioned this pull request Oct 29, 2020
Merged
adecler
adecler approved these changes Nov 3, 2020
View reviewed changes
Copy link
Member

@adecler adecler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in isolation. Would be good to have someone actually using this also review.

@FraserGreenroyd
Copy link
Contributor

@alelom can you advise an additional reviewer per @adecler comments or if you're happy this code is not yet in wide circulation to impact users? 😄

@alelom
Copy link
Member Author

alelom commented Nov 9, 2020

@alelom can you advise an additional reviewer per @adecler comments or if you're happy this code is not yet in wide circulation to impact users? 😄

This code is used only on a minor case in Speckle/3Drepo toolkit. Not widespread so safe to merge like this.

@FraserGreenroyd
Copy link
Contributor

/azp run BHoM.CheckInstaller

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

FraserGreenroyd
FraserGreenroyd approved these changes Nov 9, 2020
View reviewed changes
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy from my perspective

@FraserGreenroyd FraserGreenroyd merged commit 4a9d5dd into master Nov 9, 2020
@FraserGreenroyd FraserGreenroyd deleted the Graphics_oM-1048-ColorFragment branch November 9, 2020 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adecler adecler adecler approved these changes

@FraserGreenroyd FraserGreenroyd FraserGreenroyd approved these changes

@al-fisher al-fisher Awaiting requested review from al-fisher al-fisher is a code owner

@rwemay rwemay Awaiting requested review from rwemay rwemay is a code owner

Assignees

@alelom alelom

Labels
type:feature New capability or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Graphics_oM: add ColorFragment
3 participants
@alelom @FraserGreenroyd @adecler