Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Rhino dependency; align to new Build events #36

Closed
wants to merge 20 commits into from

Conversation

alelom
Copy link
Member

@alelom alelom commented May 13, 2020

NOTE: Depends on

BHoM/BHoM#839
BHoM/TriangleNet_Toolkit#27

Issues addressed by this PR

Closes #31
Closes #37

Test files

https://burohappold.sharepoint.com/:f:/s/BHoM/EsCg_tyvF7ZBr0P_CbVV1jgBJu0GvbIbdvIUK5VHzOiK4A?e=5E1Yem

image

Changelog

Additional comments

@alelom alelom requested a review from al-fisher May 13, 2020 16:08
@alelom alelom self-assigned this May 13, 2020
@al-fisher
Copy link
Member

Hey @alelom - have updated the CI dependances and is working now!

@alelom alelom changed the title Removed Rhino dependency Removed Rhino dependency; align to new Build events Jun 23, 2020
@alelom
Copy link
Member Author

alelom commented Aug 3, 2020

@alelom
Copy link
Member Author

alelom commented Aug 4, 2020

Created issue for the failing Push #39 @al-fisher

al-fisher
al-fisher previously approved these changes Aug 4, 2020
Copy link
Member

@al-fisher al-fisher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to approve based on the scope of this PR and the new issue being raised for unrelated uncovered bug
Approving to unblock

@alelom
Copy link
Member Author

alelom commented Aug 5, 2020

Thanks @al-fisher ! Could you please also merge as I don't have auth to do it?

@al-fisher
Copy link
Member

@alelom afraid cannot merge yest as this branch cannot be rebased due to conflicts

This reverts commit 774d131.
@alelom
Copy link
Member Author

alelom commented Aug 6, 2020

Replaced by #40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Align to Build events (copy to ProgramData) Remove dependencies on Rhinocommon/Rhinoceros_Toolkit
2 participants