Cleanups in C, Tcl, and GitHub CI #703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Newer GHC may not yet have HLS support, but we might still like to test building BSC with it. This updates the parameterized workflow to allow specifying an empty HLS version string, causing the testing of HLS to be skipped.
This notation for declaring function arguments is no longer supported in newer C standards.
Remove TCL_VER, which was not being set properly due to a syntax error and which is a duplicate definition of TCL_SUFFIX anyway. And include the suffix on the macOS lib flag, just to ensure that the right library is being linked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are misc cleanups that I made while exploring adding the new GHC 9.10.1 to our GitHub CI.
bluetcl_Main.hscthat newer compilers warn will be deprecated in newer C standards (-Wdeprecated-non-prototype).tcllibsflags are computed inplatform.sh, to removeTCL_VER(which was a duplicate definition and which was being improperly define anyway due to a syntax error). More significantly, this adds the version number to the flag for macOS (from-ltclto-ltcl8.5) -- which was intended to be added, but becauseTCL_VERwas failing to be defined properly, an empty string was being appended. It's better to have the version suffix, just to ensure that the right library is being picked up.hls_versionfield blank, to indicate that the HLS testing step should be skipped. This allows for testing newer GHC installations that are available in GHCUP but don't yet have HLS supportin GHCUP.