Fix msal-angular exports to properly support IE11, fixes #765 #414 #785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonnutter
force-pushed
the
msal-angular-ie11
branch
from
887fb07 to
baf0509
Compare
jasonnutter
changed the title
sameerag
reviewed
Jun 24, 2019
| @@ -24,7 +24,7 @@ | |||
| "rxjs": "^5.1.0", | |||
| "ts-helpers": "^1.1.1", | |||
| "zone.js": "^0.8.4", | |||
| "@azure/msal-angular": "0.1.2" | |||
| "@azure/msal-angular": "file:../.." | |||
There was a problem hiding this comment.
Does this help with picking the latest?
There was a problem hiding this comment.
Yeah, this will install the locally built version of the library, instead of what's published to npm.
sameerag
approved these changes
Jun 24, 2019
This was referenced Jun 25, 2019
jasonnutter
added a commit
that referenced
this pull request
Jul 10, 2019
DarylThayil
added a commit
that referenced
this pull request
Jul 10, 2019
Revert IE11 angular fix for main export in #785
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main export for the
msal-angularlibrary was the ES6 version of the library, which is not compatible with IE11 (I was able to reproduce this with the MSAL Angular sample). This updates the library's exports to properly export the CommonJS version of the library by default, with the ES6 version available undermodule(which matches the mainmsalpackage).Before:
After: