Ensure JsonWebToken sets X509CertificatePublicCertValue on .NET Core #1138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…when WithSendX5c is used.
jennyf19
approved these changes
May 10, 2019
There was a problem hiding this comment.
@MarkZuber hahaha...this is just what I was talking w/you about. but @wilcobmsft beat me to it.
MarkZuber
approved these changes
May 10, 2019
|
@jennyf19 @MarkZuber : can you pls. consider if the fallback should be what netstandard does. then perhaps we have platforms that should do something else. Thinking this should be an else instead of an else if … and those platforms where this is not supported should be the else if ? |
|
Aside: Seems like at least one test could be added here? |
|
Agreed with Henrik, we can future proof this by adding support for all platforms. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using WithSendX5c, the "x5c" token is not set when running on .NET Core. This change ensures this token gets set on all runtimes.