This repository has been archived by the owner on Jun 30, 2023. It is now read-only.
Add openId scope to all requests via ATHandlerBase [do not merge before discussing] #1605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check for null values on UserInfo Add a utest
|
Assuming here this is attempting to fix #1604 |
jmprieur
changed the title
|
@jmprieur @jennyf19 : if I undertstand @jennyf19 correctly, we do this for MSAL already. Seems like something we can also for for ADAL? (even though I believe the right/better approach for web apps is what JM as suggested in the issue). Anyway we should definitely improve the error message and add information to the wiki/ref-doc on this. |
henrik-me
reviewed
May 29, 2019
| @@ -326,7 +326,8 @@ protected virtual async Task PostTokenRequestAsync(AdalResultWrapper resultEx) | |||
| { | |||
| var requestParameters = new DictionaryRequestParameters(Resource, ClientKey) | |||
| { | |||
| { OAuthParameter.ClientInfo, "1" } | |||
| { OAuthParameter.ClientInfo, "1" }, | |||
| { OAuthParameter.Scope, OAuthValue.ScopeOpenId } | |||
There was a problem hiding this comment.
you may want to add a comment on why this is added (e.g. needed due to cache requirements on the idt).
There was a problem hiding this comment.
do we add openid for client creds? that would be odd ?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check for null values on UserInfo
Add a utest
null ref issue
Also did some manual testing w/all the flows on the desktop app.
If we don't want to take the change of adding openid scope to all requests, we can just fix the null ref instead.