This repository has been archived by the owner on Jun 30, 2023. It is now read-only.
Switching ui tests to use appids supplied by the lab. #1385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding dismiss keyboard to enterText method in test controller. Changing determineUser to detrmineFieldIds for extra clarity.
henrik-me
reviewed
Nov 6, 2018
core/tests/Test.Microsoft.Identity.LabInfrastructure/LabServiceApi.cs
Outdated
Show resolved
Hide resolved
henrik-me
reviewed
Nov 6, 2018
core/tests/Test.Microsoft.Identity.Core.UIAutomation/UserInformationFieldIds.cs
Outdated
Show resolved
Hide resolved
henrik-me
reviewed
Nov 6, 2018
bgavrilMS
reviewed
Nov 6, 2018
added 2 commits
November 6, 2018 19:52
removing appId from lab user class
bgavrilMS
approved these changes
Nov 7, 2018
|
I played a bit with the changes and realized that you are not setting the return uri properly. Let's sync as I'd like to push a commit on top of this to fix a few things. |
henrik-me
reviewed
Nov 7, 2018
henrik-me
reviewed
Nov 7, 2018
henrik-me
reviewed
Nov 7, 2018
henrik-me
reviewed
Nov 7, 2018
core/tests/Test.Microsoft.Identity.LabInfrastructure/ILabService.cs
Outdated
Show resolved
Hide resolved
henrik-me
reviewed
Nov 7, 2018
core/tests/Test.Microsoft.Identity.LabInfrastructure/LabServiceApi.cs
Outdated
Show resolved
Hide resolved
* Remove some test interfaces and simplify model * Use the urn:obo redirect uri in the automation app
|
Merging bogdans PR in. will address all comments with his changes included #Pending |
added 2 commits
November 7, 2018 16:20
addressing PR comments
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding dismiss keyboard to enterText method in test controller.
Changing determineUser to detrmineFieldIds for extra clarity.