Adds an AppContext switch to control HMAC key size verification. #2421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jennyf19
approved these changes
Nov 30, 2023
keegan-caruso
approved these changes
Nov 30, 2023
1 task
|
@brentschmaltz I can see this is part of v6.35.0. Do you know if it will also become part of v7 at some point? |
|
@brentschmaltz coming back on this - are you aware if this change is planned to be included in version 7 or future releases? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conforming with https://datatracker.ietf.org/doc/html/rfc7518#section-3.2 causes some users to fault.
The AppContext switch "Switch.Microsoft.IdentityModel.UnsafeRelaxHmacKeySizeValidation" can be used bypass this new check.
HMAC will still require a minimum of 128 bits.