Bundling the exception as an inner exception of the ArgumentException. #1968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renovate bot
referenced
this pull request
in orso-co/Orso.Arpa.Api
Dec 4, 2022
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [System.IdentityModel.Tokens.Jwt](https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet) | nuget | patch | `6.25.0` -> `6.25.1` | --- ### Release Notes <details> <summary>AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet</summary> ### [`v6.25.1`](https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/releases/tag/6.25.1) [Compare Source](https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/compare/6.25.0...6.25.1) Servicing release .net was throwing when JWT tokens contained claims that used escaped characters. [https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/pull/1975](https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/pull/1975) Fixed Typo in comments [https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/pull/1971](https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/pull/1971) Added inner exception to help diagnose when reading JWT tokens fails. [https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/pull/1968](https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/pull/1968) Updated comments to improve understanding of RoleClaimTypeRetriever and NameClaimTypeRetriever [https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/pull/1960](https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/pull/1960) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 10pm every weekday,every weekend,before 5am every weekday" in timezone Europe/Berlin, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/orso-co/Orso.Arpa.Api). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC40OC4xIiwidXBkYXRlZEluVmVyIjoiMzQuNDguMSJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
This was referenced Mar 28, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will embed the exception caught from the constructor as an inner exception of the ArgumentException logged by ReadToken as suggested in the issue.
Fixes #1965.
Unfortunately I'm having trouble building the projet locally and running the tests (the build process mention not finding Microsoft.IdentityModel.Protocols.SignedHttpRequest.Tests\obj\Debug\netcoreapp2.1\Microsoft.I
dentityModel.Protocols.SignedHttpRequest.Tests.GeneratedMSBuildEditorConfig.editorconfig for instance). So I'm having trouble figuring out if I need to fix the test or add a new one to make the PR work.