-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using NCC to build dist #427
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Piotr Karpala <[email protected]>
Just noticed it copies the work done in #425 with the main difference that I deleted old |
Rooting for this PR, seems the cleanest. Really need one to get merged since it makes it possible to use in GHE. |
I can try, it's been a while when I created it. |
Hey @kumaraksh1 @surenderssm would you be able to review this? |
Tagging @ShilpiRachna1 to take a look |
This PR introduces NCC to build distributable package, so that
node_modules
are no longer required in the repo.It follows solution from https://github.com/Azure/login