ARM: Add rule to enable disabling DeleteResponseCodes LintDiff rule
#298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjprescott
requested review from
bterlson,
daviwil,
markcowl,
allenjzhang and
timotheeguerin
as code owners
|
All changed packages have been documented. |
packages/typespec-azure-resource-manager/src/rules/arm-delete-response-codes.ts
Show resolved
Hide resolved
packages/typespec-azure-resource-manager/test/rules/arm-delete-response-codes.test.ts
Outdated
Show resolved
Hide resolved
tjprescott
force-pushed
the
deleteResponseCodesRule
branch
4 times, most recently
from
f636103 to
f745247
Compare
|
You can try these changes at https://cadlplayground.z22.web.core.windows.net/typespec-azure/prs/298/ Check the website changes at https://tspwebsitepr.z22.web.core.windows.net/typespec-azure/prs/298/ |
tjprescott
force-pushed
the
deleteResponseCodesRule
branch
from
1ac4c06 to
ead0b93
Compare
tjprescott
force-pushed
the
deleteResponseCodesRule
branch
3 times, most recently
from
b31e4b7 to
3f61976
Compare
tjprescott
commented
Feb 27, 2024
packages/typespec-azure-resource-manager/src/rules/arm-delete-response-codes.ts
Outdated
Show resolved
Hide resolved
tjprescott
force-pushed
the
deleteResponseCodesRule
branch
from
0cef359 to
bc10649
Compare
tjprescott
force-pushed
the
deleteResponseCodesRule
branch
from
bc10649 to
a58dd25
Compare
markcowl
requested changes
Feb 28, 2024
docs/libraries/azure-resource-manager/rules/delete-operation-response-codes.md
Outdated
Show resolved
Hide resolved
docs/libraries/azure-resource-manager/rules/delete-operation-response-codes.md
Outdated
Show resolved
Hide resolved
docs/libraries/azure-resource-manager/rules/delete-operation-response-codes.md
Outdated
Show resolved
Hide resolved
packages/typespec-azure-resource-manager/test/rules/arm-delete-response-codes.test.ts
Show resolved
Hide resolved
markcowl
requested changes
Feb 28, 2024
packages/typespec-azure-resource-manager/src/rules/arm-delete-response-codes.ts
Outdated
Show resolved
Hide resolved
packages/typespec-azure-resource-manager/src/rules/arm-delete-response-codes.ts
Outdated
Show resolved
Hide resolved
packages/typespec-azure-resource-manager/src/rules/arm-delete-response-codes.ts
Outdated
Show resolved
Hide resolved
|
@markcowl updated. Please take a look at the splash radius associated with deprecating ArmResourceDeleteAsync. It seems pretty high, at least in the tests. Hopefully real specs aren't prolifically using this bad pattern 😨 |
tjprescott
force-pushed
the
deleteResponseCodesRule
branch
3 times, most recently
from
faf1f6f to
687a77c
Compare
tjprescott
force-pushed
the
deleteResponseCodesRule
branch
2 times, most recently
from
b1bf769 to
1a67086
Compare
|
I will rebase this once approved. |
markcowl
requested changes
Feb 29, 2024
docs/libraries/azure-resource-manager/rules/delete-operation-response-codes.md
Outdated
Show resolved
Hide resolved
packages/typespec-azure-resource-manager/test/rules/arm-delete-response-codes.test.ts
Show resolved
Hide resolved
packages/typespec-azure-resource-manager/test/rules/core-operations.test.ts
Show resolved
Hide resolved
tjprescott
force-pushed
the
deleteResponseCodesRule
branch
3 times, most recently
from
949eb65 to
cc9b5e3
Compare
tjprescott
force-pushed
the
deleteResponseCodesRule
branch
from
cc9b5e3 to
b9aa706
Compare
tjprescott
commented
Mar 1, 2024
| @@ -180,6 +180,7 @@ model FlangeProperties { | |||
| ...DefaultProvisioningStateProperty; | |||
| } | |||
|
|
|||
| #suppress "deprecated" "Should replace TenantResourceDelete in the future" | |||
There was a problem hiding this comment.
@markcowl I was able to update the other samples to simply use ArmResourceDeleteWithoutOkAsync but this is an interface template of a template of a template, etc. so I just suppressed the deprecation warning...
tjprescott
commented
Mar 1, 2024
| @@ -412,6 +412,7 @@ op ArmResourceDeleteAsyncBase< | |||
| * @template Response Optional. The success response(s) for the delete operation | |||
| * @template Error Optional. The error response, if non-standard. | |||
| */ | |||
| #deprecated "Use 'ArmResourceDeleteWithoutOkAsync' instead" | |||
There was a problem hiding this comment.
You can see the cascading effects of formally deprecating this.
|
@markcowl all comments should be resolved. The REST API specs PR has been merged |
allenjzhang
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/Azure/typespec-azure-pr/issues/3836
Impact
azure-openapi-validator
Azure/azure-openapi-validator#668