Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add public_network_access_enabled variable #26

Merged
merged 3 commits into from
Feb 24, 2021
Merged

Add public_network_access_enabled variable #26

merged 3 commits into from
Feb 24, 2021

Conversation

kcirrr
Copy link
Contributor

@kcirrr kcirrr commented Feb 4, 2021

Fixes #000

Changes proposed in the pull request:

  • Add public_network_access_enabled variable

Last year this option was added to the azurerm_postgresql_server resource in the azurerm provider, it would be nice if this option could be used in this module. More information: https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/postgresql_server#public_network_access_enabled

I've formatted and tested the change.

@ghost
Copy link

ghost commented Feb 4, 2021

CLA assistant check
All CLA requirements met.

Copy link
Contributor

@yupwei68 yupwei68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! 🚀 Overall, this looks almost good to me. Just please add this feature into the test in test/fixture to integrate the test CI .

@kcirrr
Copy link
Contributor Author

kcirrr commented Feb 5, 2021

I've added the feature to the test/fixture. I looks like the test failed due to a problem with pulling the docker image, not due to the change.

Copy link
Contributor

@yupwei68 yupwei68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants