fix #69 also comply with TF best practices and add node pools #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f resouces to match tf best practice, added support for node pools
AlexBevan
changed the title
|
@yupwei68 is this change breaking solely because of the |
|
@AlexBevan any news on this feature ? |
I've stopped contributing and using these these repos. MSFT aren't maintaining them well enough, looks like the focus is on on the monolith teraform-azurerm-caf module. |
nlamirault
added a commit
to nlamirault/terraform-azurerm-aks-ms
that referenced
this pull request
Oct 19, 2021
See: Azure#89 Signed-off-by: Nicolas Lamirault <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a big breaking change due to changing the name of the terraform resources to comply with terraform best practices.
Fixes #69
Changes proposed in the pull request: