Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement node_network_profile for default node pool #598

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

zioproto
Copy link
Collaborator

@zioproto zioproto commented Nov 4, 2024

Describe your changes

Implements default_network_profile for the default node pool

Issue number

#524

Checklist before requesting a review

  • The pr title can be used to describe what this pr did in CHANGELOG.md file
  • I have executed pre-commit on my machine
  • I have passed pr-check on my machine

Thanks for your cooperation!

Copy link
Member

@lonegunmanb lonegunmanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zioproto I see allowed_host_ports and application_security_group_ids in node_network_profile block, don't we need to add them in this pr?

@zioproto
Copy link
Collaborator Author

@zioproto I see allowed_host_ports and application_security_group_ids in node_network_profile block, don't we need to add them in this pr?

The goal of this PR was to bring feature parity between the current extra extra_node_pool.tf and the default nodepool.

dynamic "node_network_profile" {
for_each = each.value.node_network_profile == null ? [] : ["node_network_profile"]
content {
node_public_ip_tags = each.value.node_network_profile.node_public_ip_tags
}
}

If I implement allowed_host_ports I should add it in both places, maybe I can do that in a different PR ?
It would be easier to test, because I should extend also end to end tests to cover all those scenarios.

Copy link
Member

@lonegunmanb lonegunmanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lonegunmanb lonegunmanb merged commit 1c8ee49 into main Nov 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants