Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect e2e test code so it could pass on our local machine #395

Merged
merged 1 commit into from
Jun 19, 2023

Conversation

lonegunmanb
Copy link
Member

Describe your changes

The e2e test TestExamples_differentLocationForLogAnalyticsSolution would failed when we run e2e test on our local machine because of the incorrect initialization. This pr fixed this incorrect e2e test.

Issue number

#000

Checklist before requesting a review

  • The pr title can be used to describe what this pr did in CHANGELOG.md file
  • I have executed pre-commit on my machine
  • I have passed pr-check on my machine

Thanks for your cooperation!

@zioproto
Copy link
Contributor

LGTM, I tested and everything works as expected:

PASS
ok      github.com/Azure/terraform-azurerm-aks/e2e      2541.921s

@zioproto
Copy link
Contributor

The E2E test in GitHub failed because of https://www.ipify.org/ returning Bad Gateway

│     │ while calling jsondecode(str)
│     │ data.curl.public_ip[0].response is "Bad Gateway"

@lonegunmanb
Copy link
Member Author

The E2E test in GitHub failed because of https://www.ipify.org/ returning Bad Gateway

│     │ while calling jsondecode(str)
│     │ data.curl.public_ip[0].response is "Bad Gateway"

I'm thinking of composing a new small module that returns your current public ip, and in this new module we should retrieve public ip from multiple APIs in case one is not available temporarily.

@lonegunmanb lonegunmanb temporarily deployed to acctests June 19, 2023 00:08 — with GitHub Actions Inactive
Copy link
Collaborator

@jiaweitao001 jiaweitao001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@jiaweitao001 jiaweitao001 merged commit 3dcba31 into Azure:main Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants