Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output Kubernetes Cluster Network Profile #333

Merged

Conversation

joshua-giumelli-deltatre
Copy link
Contributor

Describe your changes

Small PR to output the network_profile attribute of the azurerm_kubernetes_cluster resource.

This is so that it is easier to discover the public IP address associated with the cluster's load balancer, e.g. to follow examples from the Azure Terraform provider like this.

Issue number

#000

Checklist before requesting a review

  • The pr title can be used to describe what this pr did in CHANGELOG.md file
  • I have executed pre-commit on my machine
  • I have passed pr-check on my machine

Thanks for your cooperation!

@lonegunmanb
Copy link
Member

Hi @joshua-giumelli-deltatre thanks for opening this pr! We have a CI pipeline for this repo, would you please run the following command on your side to update readme file? Thanks:

docker run --rm -v $(pwd):/src -w /src mcr.microsoft.com/azterraform:latest make pre-commit

For Windows:

docker run --rm -v ${pwd}:/src -w /src mcr.microsoft.com/azterraform:latest make pre-commit

@github-advanced-security
Copy link

You have successfully added a new CodeQL configuration .github/workflows/pr-check.yaml:prepr-check. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@github-actions
Copy link
Contributor

Potential Breaking Changes in ad80539:
[delete] "Variables.create_role_assignment_network_contributor.Name" from 'create_role_assignment_network_contributor' to ''

@joshua-giumelli-deltatre joshua-giumelli-deltatre temporarily deployed to acctests March 24, 2023 01:26 — with GitHub Actions Inactive
@lonegunmanb
Copy link
Member

Hi @joshua-giumelli-deltatre thanks for the update, all have been settled down and we're good to go, the only thing I'd have to ask you to do us a favor is please read policy bot's comment and sign the agreement, thanks!

@joshua-giumelli-deltatre
Copy link
Contributor Author

@microsoft-github-policy-service agree company="Deltatre"

@joshua-giumelli-deltatre
Copy link
Contributor Author

Apologies for the hold up @lonegunmanb, is there anything more that needs to happen before this can be merged?

@lonegunmanb lonegunmanb merged commit b129047 into Azure:main Apr 6, 2023
@lonegunmanb
Copy link
Member

Apologies for the hold up @lonegunmanb, is there anything more that needs to happen before this can be merged?

No worries @joshua-giumelli-deltatre, we'll release this feature in our next release, but the next release would be 7.0.0 and it would be a major version with some breaking changes. If you're eager to use this feature ASAP and don't want to take any risk, I think I can release a patch version for this pr first. WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants