Add key_vault_secrets_provider #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lonegunmanb
requested changes
Jul 7, 2022
There was a problem hiding this comment.
Thanks for opening this PR @zioproto , almost LGTM except some tiny questions.
I'll test this pr on our CI branch.
variables.tf
Outdated
| type = bool | ||
| default = false | ||
| nullable = false | ||
|
|
There was a problem hiding this comment.
Can we remove this blank line please?
zioproto
force-pushed
the
azure-keyvault-csi-driver
branch
2 times, most recently
from
19d7426 to
3130378
Compare
|
Hi @zioproto , the pr has conflict with master branch since we've merged some prs today, would you please solve it? Thanks! |
zioproto
force-pushed
the
azure-keyvault-csi-driver
branch
from
3130378 to
785fa23
Compare
Done ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for the argument
key_vault_secrets_provider:https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/kubernetes_cluster#key_vault_secrets_provider
https://docs.microsoft.com/en-us/azure/aks/csi-secrets-store-driver
Note that the output for this feature was already implemented in the
output.tffile.Fixes #210