Adding the private_dns_zone_id input variable #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lonegunmanb
requested changes
Jun 28, 2022
lonegunmanb
approved these changes
Jun 30, 2022
There was a problem hiding this comment.
Thanks @fgauna12 , LGTM but it seems like we have some conflict due to recently upgrades. Would you please solve the conflict? Thanks!
lonegunmanb
requested changes
Jun 30, 2022
There was a problem hiding this comment.
Thanks @fgauna12 , LGTM but it seems like we have some conflict due to recently upgrades. Would you please solve the conflict? Thanks!
|
@lonegunmanb - I resolved the merge conflicts before you wrote the comment. I don't see any more merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #120
Changes proposed in the pull request:
Added an optional input variable to accept private_dns_zone_id
First time contributing to this repo. Hopefully, this helps. The tests passed and ran terrafmt.
BTW: Sorry about the closed, duplicate, unmerged pull requests. Third time is the charm! 😄